NOISSUE - Add functionality to sdk-js #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drasko
changed the title
added 10 commits
September 13, 2023 15:05
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
added 5 commits
September 14, 2023 11:00
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
added 3 commits
October 2, 2023 20:06
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
SammyOina
requested changes
Oct 12, 2023
| const options = { | ||
| method: "post", | ||
| maxBodyLength: Infinity, | ||
| url: `${this.bootstraps_url}/things/${this.bootstrapsEndpoint}`, |
There was a problem hiding this comment.
consider using the url object https://developer.mozilla.org/en-US/docs/Web/API/URL/URL
|
|
||
|
|
||
| class Errors { | ||
| HandleError(error_dict, status_code) { |
There was a problem hiding this comment.
where is error_dict defined
| 401: "Missing or invalid access token provided.", | ||
| }, | ||
| login: { | ||
| 404: "A non-existent entity request.", |
There was a problem hiding this comment.
Suggested change
| 404: "A non-existent entity request.", |
| let subtopic = ""; | ||
|
|
||
| if (chan_name_parts.length == 2) { | ||
| subtopic = chan_name_parts[1].replace(".", "/", -1); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
SammyOina
requested changes
Oct 12, 2023
SammyOina
requested changes
Oct 12, 2023
| "Content-Type": this.content_type, | ||
| Authorization: `Bearer ${token}`, | ||
| }, | ||
| data: JSON.stringify(config), |
There was a problem hiding this comment.
axios converts js objects to json so no need for JSON.stringify() look at other simillar cases
| }; | ||
| return axios.request(options) | ||
| .then((_response) => { | ||
| return "DELETED"; |
There was a problem hiding this comment.
perhaps return the status code
added 3 commits
October 15, 2023 23:56
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
added 2 commits
October 16, 2023 01:22
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
SammyOina
reviewed
Oct 17, 2023
SammyOina
requested changes
Oct 17, 2023
SammyOina
requested changes
Oct 29, 2023
|
I've done all these changes in the pull request #4. |
SammyOina
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Add functioning code to JS SDK.
Which issue(s) does this PR fix/relate to?
No issue
List any changes that modify/break current functionality
Have you included tests for your changes?
Yes. Manually tested.
Did you document any new/modified functionality?
No
Notes