MG-211 - Update horizontal bar chart fo fetch data from back-end #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixgateru
force-pushed
the
MG-211_horizontal_bar
branch
from
4f3c7e9 to
ac961d1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
=======================================
Coverage ? 76.74%
=======================================
Files ? 3
Lines ? 215
Branches ? 0
=======================================
Hits ? 165
Misses ? 34
Partials ? 16 ☔ View full report in Codecov by Sentry. |
felixgateru
force-pushed
the
MG-211_horizontal_bar
branch
2 times, most recently
from
c9ec956 to
628742f
Compare
ianmuchyri
requested changes
Mar 18, 2024
| > | ||
| Close | ||
| </button> | ||
| <button type="button" class="btn btn-secondary" onclick="resetForm();">Close</button> |
There was a problem hiding this comment.
do this for the dismiss button at the top of the modal too. They should function the same.
| case "startTime": | ||
| case "stopTime": | ||
| const inputDate = new Date(pair[1]); | ||
| chartData[pair[0]] = inputDate.getTime() * 1e6; |
There was a problem hiding this comment.
No need to convert it to nanoseconds. This is done automatically on the backend side.
Signed-off-by: felix.gateru <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
felixgateru
force-pushed
the
MG-211_horizontal_bar
branch
from
628742f to
179d58b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Populate horizontal bar chart with data from back-end
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified functionality?
Notes