MG-209 - Update Line charts #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmuchyri
force-pushed
the
209-linechars
branch
from
e362b6a to
30040c5
Compare
dborovcanin
force-pushed
the
209-linechars
branch
from
40e628e to
5860db9
Compare
ianmuchyri
force-pushed
the
209-linechars
branch
from
c6adf24 to
518329e
Compare
dborovcanin
requested changes
Mar 13, 2024
ui/web/static/js/charts.js
Outdated
| async function getData(linechart,chartData) { | ||
| try { | ||
| const response = await fetch( | ||
| "/data?channel=" + chartData.channel + |
There was a problem hiding this comment.
We will need to take into account the UI prefix here.
Signed-off-by: ianmuchyri <[email protected]>
Signed-off-by: ianmuchyri <[email protected]>
dborovcanin
force-pushed
the
209-linechars
branch
from
ef8c43a to
f17fcc0
Compare
Signed-off-by: ianmuchyri <[email protected]>
dborovcanin
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Update line charts to be able to populate the charts with the data from the readers.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified functionality?
Notes