NOISSUE - Add manager and architecture documentation #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rodney Osodo <[email protected]>
dborovcanin
approved these changes
Jan 10, 2025
drasko
requested changes
Jan 10, 2025
docs/images/architecture.png
Outdated
There was a problem hiding this comment.
It would be good to add OCI Registry in the picture below Proxy, because this is what Proxy is for. Without it - it looks like the Proxy is there for communication between Proplets
docs/architecture.md
Outdated
|
|
||
| ### Proxy | ||
|
|
||
| The Proxy service is responsible for fetching container images from a registry and distributing them to proplets. It handles authentication with the registry and splits the container images into chunks for efficient distribution. |
There was a problem hiding this comment.
Mention that it is fr the OCI registry
Signed-off-by: Rodney Osodo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
The is a documentation PR because it add manager and architectural documentation
What does this do?
Adds documentation regarding manager service and the overall architectural decision behind propeller
Which issue(s) does this PR fix/relate to?
No issue
Have you included tests for your changes?
No tests
Did you document any new/modified features?
Yes, I have updated the documentation for the new feature.
Notes