-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSSDK-95 - Update channels service to match new access control #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b6145b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: wambuipixel <[email protected]>
Signed-off-by: wambuipixel <[email protected]>
wambui-pixel
force-pushed
the
updatechannels
branch
from
November 20, 2024 08:35
6c4db6b
to
d003ec7
Compare
Signed-off-by: wambuipixel <[email protected]>
Signed-off-by: wambuipixel <[email protected]>
Signed-off-by: wambuipixel <[email protected]>
Signed-off-by: wambuipixel <[email protected]>
wambui-pixel
changed the title
DRAFT - JSSDK-95 - Update channels service to match new auth
JSSDK-95 - Update channels service to match new access control
Nov 20, 2024
Signed-off-by: wambuipixel <[email protected]>
Signed-off-by: wambuipixel <[email protected]>
dborovcanin
approved these changes
Nov 21, 2024
ianmuchyri
requested changes
Nov 21, 2024
Signed-off-by: wambuipixel <[email protected]>
ianmuchyri
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request title should be
JSSDK-XXX - description
orNOISSUE - description
where XXX is ID of issue that this PR relate to.Please review the CONTRIBUTING.md file for detailed contributing guidelines.
What does this do?
Updates channels to match new auth
Which issue(s) does this PR fix/relate to?
Resolves #95
Put here
Resolves #XXX
to auto-close the issue that your PR fixes (if such)List any changes that modify/break current functionality
n/a
Have you included tests for your changes?
yes
Did you document any new/modified functionality?
yes
Notes