MG - 41 - Refactor User enable and disable #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ianmuchyri <[email protected]>
Signed-off-by: ianmuchyri <[email protected]>
🦋 Changeset detectedLatest commit: 63fe0da The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: ianmuchyri <[email protected]>
wambui-pixel
requested changes
Nov 29, 2024
Signed-off-by: ianmuchyri <[email protected]>
wambui-pixel
approved these changes
Nov 29, 2024
dborovcanin
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request title should be
JSSDK-XXX - descriptionorNOISSUE - descriptionwhere XXX is ID of issue that this PR relate to.Please review the CONTRIBUTING.md file for detailed contributing guidelines.
What does this do?
This pr updates the user service enable and disable to only take the
userIdinstead of the whole user object as only the user id is required. We also update the jsdocs of the user service.Which issue(s) does this PR fix/relate to?
Resolves #41
Put here
Resolves #XXXto auto-close the issue that your PR fixes (if such)List any changes that modify/break current functionality
None
Have you included tests for your changes?
Yes
Did you document any new/modified functionality?
yes
Notes