SMQ-2545 - Add User Rust SDK #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dborovcanin
requested changes
Dec 24, 2024
There was a problem hiding this comment.
This is way to many generated files for relatively simple SDK. Please:
- Clean up the generated files and try to reduce the amount of generated files.
- Remove useless Markdown docs.
- Do not generate package per MG service - check how it's done in the Go SDK.
- Update README with meaningfull instructions on how to use SDK, install tool that's used to generate it and how to use the tool with existing SuperMQ repo.
- Update examples to make some use of it (i.e. registrer, login, create domain, group, client, channel, connect them, send an HTTP message).
drasko
requested changes
Jan 12, 2025
bootstrap/.gitignore
Outdated
There was a problem hiding this comment.
Bootstrap is removed from SuperMQ, so please take care to include only services in SuperMQ. Change and correct OpenAPI files if needed.
There was a problem hiding this comment.
I have deleted all files pertaining to Bootstrap
|
I have refactored the code as suggested. Please let me know if this works or any further improvements to it. I just need to improve examples. |
added 5 commits
January 13, 2025 10:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds the following functionality: Adding a Rust SDK to supreme
.
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No, I have not included tests because its a draft PR.
Did you document any new/modified features?
No, I have not updated the documentation because its a draft PR.