Skip to content

Commit

Permalink
fix: Consume github service as js module
Browse files Browse the repository at this point in the history
Since we are using ncc to bundle the code. There is an issue when
enabling `"allowImportingTsExtensions": true` in typescript config which
won't recognize `noEmit:true` set and it will fail the boundling saying
something in the lines of missing noEmit key.

Therefore, there is a reason to back up on the allowImportingTsExtension
and keep using the esm standard of import which will be by adding the js
extension even though we are using ts.
  • Loading branch information
Baraujo25 committed Nov 22, 2024
1 parent c060837 commit a645854
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/release-builder.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { Arguments } from './args.js'
import path from 'path'
import { readdir, readFile } from 'fs/promises'
import type { Plugin, PluginVersion } from './jmeter-plugins.d.ts'
import type { Asset } from './github.ts'
import type { Plugin, PluginVersion } from './jmeter-plugins.d.js'
import type { Asset } from './github.js'

export class ReleaseBuilder {
PLUGINS_REPOSITORY_FILE_PATH = 'jmeter-plugins/site/dat/repo/'
Expand Down

0 comments on commit a645854

Please sign in to comment.