Updates re unicast_src_ip #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a unicast VRRP instance is configured and the unicast_src_ip does not exist on the system, then the bind() fails and the sockets are not opened. This commit ensures that in that case vrrp->sockets is not dereferenced. This is not a real fix to the problem. We need to track the addition and removal of unicast_src_ip addresses, and enter fault state if the address in not configured, or when it is removed. Signed-off-by: Quentin Armitage <[email protected]>
If the interface is not configured, we can't know what interface to add the VMAC to. Signed-off-by: Quentin Armitage <[email protected]>
Commit 0400738 - "vrrp: don't allow unicast instance without interface to have a VMAC" caused keepalived to fail to compile if VMACs were not enabled.
This allows creating and configuring unicast sockets before the configured source address is added to the system. Signed-off-by: Quentin Armitage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix segfault if unicast_src_ip is not configured on interface, and allow bind() to work when address in not configured on interface.