Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test page for react hook form demo #70

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kevin-andrivia
Copy link

TODO:

  1. Atur styling form, buat tampilan label dan input saling berdekatan dan rapi
  2. Error message dipindahkan ke bawah input
  3. Tambahkan contoh validasi string length / number length
  4. Tambahkan validasi date range
  5. Cari tahu apakah zod ada mekanisme message templating, jadi bisa set template message yang universal
  6. Contoh file upload

@Tieantono
Copy link
Contributor

This is for #9

Copy link
Contributor

@ryanelian ryanelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename test page --> form sample page atau something lah. jangan terlalu generic bro

@Tieantono
Copy link
Contributor

TODO:

  1. Atur styling form, buat tampilan label dan input saling berdekatan dan rapi
  2. Error message dipindahkan ke bawah input
  3. Tambahkan contoh validasi string length / number length
  4. Tambahkan validasi date range
  5. Cari tahu apakah zod ada mekanisme message templating, jadi bisa set template message yang universal
  6. Contoh file upload

Please handle these tasks on this week.

@Tieantono
Copy link
Contributor

Need further review and testing @robertowu16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants