Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially revert #2351 after upgrading to Pest v3 #2352

Open
greatislander opened this issue Nov 6, 2024 · 1 comment
Open

Potentially revert #2351 after upgrading to Pest v3 #2352

greatislander opened this issue Nov 6, 2024 · 1 comment
Assignees
Milestone

Comments

@greatislander
Copy link
Collaborator

greatislander commented Nov 6, 2024

We may be able to revert #2351 after we upgrade to Pest v3 and PHPUnit v11.

@greatislander greatislander self-assigned this Nov 6, 2024
@jobara
Copy link
Collaborator

jobara commented Nov 6, 2024

See conversation in accessibility exchange channel https://matrix.to/#/!QRQCoXAWrIjYQVYaai:matrix.org/$U9Mky16eppoJPRaSNFbiX2FGRbYyMtvcuI4CwBb-ueM?via=matrix.org

sebastianbergmann/phpunit#5225 should have fixed the upstream issue in phpunit, allowing named parameters to be used from the datasource. It seems that Pest v3 should also now support this, except the case where the parameters count mismatches ( pestphp/pest#1232 ).

@michelled michelled added this to the 1.6.0 milestone Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants