Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix deprecation errors #2351

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

greatislander
Copy link
Collaborator

Fixes deprecation errors related to named parameters in test datasets. See Matrix discussion: https://matrix.to/#/!QRQCoXAWrIjYQVYaai:matrix.org/$NddpSUztTX62Uvwi-12C-750zXpWVxtDBV5ObBmIf8c?via=matrix.org

Prerequisites

If this PR changes PHP code or dependencies:

  • I've run composer format and fixed any code formatting issues.
  • I've run composer analyze and addressed any static analysis issues.
  • I've run php artisan test and ensured that all tests pass.
  • I've run composer localize to update localization source files and committed any changes.

If this PR changes CSS or JavaScript code or dependencies:

  • I've run npm run lint and fixed any linting issues.
  • I've run npm run build and ensured that CSS and JavaScript assets can be compiled.

@greatislander greatislander self-assigned this Nov 6, 2024
@greatislander greatislander enabled auto-merge (squash) November 6, 2024 17:01
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.35%. Comparing base (227a884) to head (45d7470).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #2351   +/-   ##
=========================================
  Coverage     97.35%   97.35%           
  Complexity     2188     2188           
=========================================
  Files           338      338           
  Lines         10243    10243           
=========================================
  Hits           9972     9972           
  Misses          271      271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jobara jobara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is potentially a temporary change, see #2352

@greatislander greatislander merged commit e04e0d5 into dev Nov 6, 2024
10 checks passed
@greatislander greatislander deleted the test/fix-deprecation-errors branch November 6, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants