Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: split the healthcheck and external Node Ping paths (resolve #2042) #2152

Merged
merged 5 commits into from
Mar 25, 2024
Merged

fix: split the healthcheck and external Node Ping paths (resolve #2042) #2152

merged 5 commits into from
Mar 25, 2024

Conversation

marvinroman
Copy link
Contributor

Split the healthcheck and external Node Ping paths that are checked.

Added the custom status pages to be exceptions from maintenance mode so they can be hit by kubernetes even when the site is in maintenance mode.

@marvinroman marvinroman linked an issue Feb 29, 2024 that may be closed by this pull request
Latest compiled component path not found. #2131
Open
@codecov Codecov
Copy link

codecov bot commented Feb 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (0058963) to head (274316a).

Additional details and impacted files 
@@            Coverage Diff            @@
##                dev    #2152   +/-   ##
=========================================
  Coverage     97.93%   97.93%           
  Complexity     2147     2147           
=========================================
  Files           333      333           
  Lines          9799     9799           
=========================================
  Hits           9597     9597           
  Misses          202      202

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SantiagoG-Colab SantiagoG-Colab mentioned this pull request Mar 8, 2024
Open
jobara
jobara reviewed Mar 25, 2024
View reviewed changes
.kube/app/Dockerfile Outdated
@@ -65,7 +65,7 @@ COPY . $APP_DIR

RUN composer install

RUN . "$NVM_DIR/nvm.sh" && nvm use $NODE_VERSION && npm ci
RUN . "$NVM_DIR/nvm.sh" && nvm use $NODE_VERSION && npm ci && npm run build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marvinroman this is interesting because there is a post install script in the package.json file; which should be running npm run build. When I run npm ci locally, the build is also run. Can you see if the build is run as part of the post install in docker? Maybe something isn't working or maybe something else is at play.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jobara I have removed.

I can confirm that the build directory was mapped into the running container which probably caused the anomaly in my local environment.

@jobara jobara changed the title 2131 latest compiled component path not found fix: split the healthcheck and external Node Ping paths (resolve #2042) Mar 25, 2024
@jobara jobara removed a link to an issue Mar 25, 2024
Latest compiled component path not found. #2131
Open
@jobara jobara linked an issue Mar 25, 2024 that may be closed by this pull request
Node ping errors nightly on dev during database reset #2042
Closed
1 task
@jobara jobara added this to the 1.4.0 milestone Mar 25, 2024
@jobara jobara enabled auto-merge (squash) March 25, 2024 17:10
@jobara jobara disabled auto-merge March 25, 2024 17:10
@jobara jobara enabled auto-merge (squash) March 25, 2024 17:10
@jobara jobara merged commit ba1c04d into dev Mar 25, 2024
8 checks passed
@jobara jobara deleted the 2131-latest-compiled-component-path-not-found branch March 25, 2024 17:12
@github-actions github-actions bot mentioned this pull request Mar 25, 2024
Merged
theaccessibilityexchange added a commit that referenced this pull request Jul 29, 2024
@marvinroman @jobara
@theaccessibilityexchange @dependabot @github-actions
Promote staging to production (#2235)
2ff92dd 
* Add / edit deploy configuration

* Add / edit deploy configuration

* Add / edit deploy configuration

* Add / edit deploy configuration

* Add / edit deploy configuration

* Add / edit deploy configuration

* Add / edit deploy configuration

* Add / edit deploy configuration

* Add / edit deploy configuration

* fix: split the healthcheck and external Node Ping paths (resolve #2042) (#2152)

* ci: 👷 changed internal healthcheck path

* fix: create maintance mode exception paths that will bypass maintenance mode

* ci: 👷 added vite build to container

* build: 👷 removed npm build since it is redundant

---------

Co-authored-by: Justin Obara <[email protected]>

* feat: enable searching for engagements (resolves #2079( (#2165)

* fix: org url on project page goes to 404

* feat: browse engagements

* test: remove seeders from engagement tests

* style: remove trailing commas from json file

* feat: engagements i've joined page

* feat: my projects page only for organizations

* test: update organization tests

* chore(localization): update translations (#2179)

* chore(localization): translate en.json into French, Canada

* chore(localization): translate routes.php into French, Canada

* chore(localization): translate en.json into French, Canada

---------

Co-authored-by: Justin Obara <[email protected]>

* fix: php values breaking alpine model data (resolves #2180) (#2185)

* fix: php values breaking alpine model data
* fix: cannot remove other access need
* fix: training module progress not recorded
* test: fix tests for encoded urls in blade views

fix: cannot remove other access need
fix: training module progress not recorded

* chore(deps): bump ralphjsmit/livewire-urls from 1.3.1 to 1.4.0 (#2186)

Bumps [ralphjsmit/livewire-urls](https://github.com/ralphjsmit/livewire-urls) from 1.3.1 to 1.4.0.
- [Release notes](https://github.com/ralphjsmit/livewire-urls/releases)
- [Changelog](https://github.com/ralphjsmit/livewire-urls/blob/main/CHANGELOG.md)
- [Commits](ralphjsmit/livewire-urls@1.3.1...1.4.0)

---
updated-dependencies:
- dependency-name: ralphjsmit/livewire-urls
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump vite-plugin-static-copy from 1.0.1 to 1.0.2 (#2188)

Bumps [vite-plugin-static-copy](https://github.com/sapphi-red/vite-plugin-static-copy) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/sapphi-red/vite-plugin-static-copy/releases)
- [Changelog](https://github.com/sapphi-red/vite-plugin-static-copy/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sapphi-red/vite-plugin-static-copy/compare/[email protected]@1.0.2)

---
updated-dependencies:
- dependency-name: vite-plugin-static-copy
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump stylelint-plugin-logical-css from 1.0.0 to 1.2.0 (#2189)

Bumps [stylelint-plugin-logical-css](https://github.com/yuschick/stylelint-plugin-logical-css) from 1.0.0 to 1.2.0.
- [Commits](https://github.com/yuschick/stylelint-plugin-logical-css/commits)

---
updated-dependencies:
- dependency-name: stylelint-plugin-logical-css
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Justin Obara <[email protected]>

* chore(deps-dev): bump postcss from 8.4.35 to 8.4.38 (#2191)

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.35 to 8.4.38.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.35...8.4.38)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Justin Obara <[email protected]>

* chore(deps): bump spatie/laravel-options from 1.1.0 to 1.1.1 (#2187)

Bumps [spatie/laravel-options](https://github.com/spatie/laravel-options) from 1.1.0 to 1.1.1.
- [Release notes](https://github.com/spatie/laravel-options/releases)
- [Changelog](https://github.com/spatie/laravel-options/blob/main/CHANGELOG.md)
- [Commits](spatie/laravel-options@1.1.0...1.1.1)

---
updated-dependencies:
- dependency-name: spatie/laravel-options
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Justin Obara <[email protected]>

* chore(deps): bump @vimeo/player from 2.20.1 to 2.22.0 (#2192)

Bumps [@vimeo/player](https://github.com/vimeo/player.js) from 2.20.1 to 2.22.0.
- [Release notes](https://github.com/vimeo/player.js/releases)
- [Commits](vimeo/player.js@v2.20.1...v2.22.0)

---
updated-dependencies:
- dependency-name: "@vimeo/player"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Justin Obara <[email protected]>

* chore(deps-dev): bump prettier from 3.0.3 to 3.2.5 (#2193)

Bumps [prettier](https://github.com/prettier/prettier) from 3.0.3 to 3.2.5.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.0.3...3.2.5)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Justin Obara <[email protected]>

* chore(deps): bump axlon/laravel-postal-code-validation from 3.5.0 to 3.6.0 (#2190)

chore(deps): bump axlon/laravel-postal-code-validation

Bumps [axlon/laravel-postal-code-validation](https://github.com/axlon/laravel-postal-code-validation) from 3.5.0 to 3.6.0.
- [Release notes](https://github.com/axlon/laravel-postal-code-validation/releases)
- [Changelog](https://github.com/axlon/laravel-postal-code-validation/blob/3.x/CHANGELOG.md)
- [Commits](axlon/laravel-postal-code-validation@v3.5.0...v3.6.0)

---
updated-dependencies:
- dependency-name: axlon/laravel-postal-code-validation
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Justin Obara <[email protected]>

* chore(deps-dev): bump spatie/laravel-ray from 1.35.1 to 1.36.0 (#2194)

Bumps [spatie/laravel-ray](https://github.com/spatie/laravel-ray) from 1.35.1 to 1.36.0.
- [Release notes](https://github.com/spatie/laravel-ray/releases)
- [Changelog](https://github.com/spatie/laravel-ray/blob/main/CHANGELOG.md)
- [Commits](spatie/laravel-ray@1.35.1...1.36.0)

---
updated-dependencies:
- dependency-name: spatie/laravel-ray
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Justin Obara <[email protected]>

* chore(deps): bump filament/spatie-laravel-settings-plugin from 3.2.34 to 3.2.35 (#2195)

chore(deps): bump filament/spatie-laravel-settings-plugin

Bumps [filament/spatie-laravel-settings-plugin](https://github.com/filamentphp/spatie-laravel-settings-plugin) from 3.2.34 to 3.2.35.
- [Commits](filamentphp/spatie-laravel-settings-plugin@v3.2.34...v3.2.35)

---
updated-dependencies:
- dependency-name: filament/spatie-laravel-settings-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump vite from 5.1.5 to 5.1.7 (#2197)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.1.5 to 5.1.7.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v5.1.7/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.1.7/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: improved sign up/getting started workflow (resolves #2142) (#2184)

* fix: prompt doesn't dismiss when action followed

* feat: add link to rewatch introduction video

* refactor: move prompts from getting started to dashboard

* feat: new getting started flow for Individuals

Work in progress, still missing tests, updates to interpretation files, and etc.

* feat: consolidate application form

* feat: update interpretation placeholder and seeder

* chore(localization): run localization

* style: fix trailing comma in json file

* test: update tests

* test: add test for individual getting started flow

fix: prompt doesn't dismiss when action followed
feat: add link to rewatch introduction video
feat: consolidate application form

* chore(localization): update translations (#2202)

* fix: remove reference to ac_application and cc_application (resolves #2203) (#2205)

* fix: estimate and agreement copy (resolves #2204) (#2206)

* fix: estimate and agreement copy

* fix: regulated organization contact info not displayed on public page

fix: regulated organization contact info not displayed on public page

* chore(localization): update translations (#2208)

chore(localization): translate en.json into French, Canada

* chore(release): release 1.4.0 (#2183)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Promotion from dev to staging (#2234)

* chore(deps-dev): bump pestphp/pest from 2.33.6 to 2.34.8 (#2230)

* chore(deps-dev): bump pestphp/pest from 2.33.6 to 2.34.8

Bumps [pestphp/pest](https://github.com/pestphp/pest) from 2.33.6 to 2.34.8.
- [Release notes](https://github.com/pestphp/pest/releases)
- [Changelog](https://github.com/pestphp/pest/blob/2.x/RELEASE.md)
- [Commits](pestphp/pest@v2.33.6...v2.34.8)

---
updated-dependencies:
- dependency-name: pestphp/pest
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* build: fixed healthcheck for meilisearch

* build: 🐛 removed IP restrictions for local nginx status healthcheck

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marvin Roman <[email protected]>

* chore(deps-dev): bump vite from 5.1.7 to 5.3.2 (#2229)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.1.7 to 5.3.2.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v5.3.2/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump postcss-custom-media from 10.0.2 to 10.0.7 (#2228)

Bumps [postcss-custom-media](https://github.com/csstools/postcss-plugins/tree/HEAD/plugins/postcss-custom-media) from 10.0.2 to 10.0.7.
- [Changelog](https://github.com/csstools/postcss-plugins/blob/main/plugins/postcss-custom-media/CHANGELOG.md)
- [Commits](https://github.com/csstools/postcss-plugins/commits/HEAD/plugins/postcss-custom-media)

---
updated-dependencies:
- dependency-name: postcss-custom-media
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump braces from 3.0.2 to 3.0.3 (#2227)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump stylelint from 16.2.0 to 16.6.1 (#2223)

Bumps [stylelint](https://github.com/stylelint/stylelint) from 16.2.0 to 16.6.1.
- [Release notes](https://github.com/stylelint/stylelint/releases)
- [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md)
- [Commits](stylelint/stylelint@16.2.0...16.6.1)

---
updated-dependencies:
- dependency-name: stylelint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump barryvdh/laravel-debugbar from 3.10.4 to 3.13.5 (#2222)

Bumps [barryvdh/laravel-debugbar](https://github.com/barryvdh/laravel-debugbar) from 3.10.4 to 3.13.5.
- [Release notes](https://github.com/barryvdh/laravel-debugbar/releases)
- [Commits](barryvdh/laravel-debugbar@v3.10.4...v3.13.5)

---
updated-dependencies:
- dependency-name: barryvdh/laravel-debugbar
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump postcss-logical from 7.0.0 to 7.0.1 (#2220)

Bumps [postcss-logical](https://github.com/csstools/postcss-plugins/tree/HEAD/plugins/postcss-logical) from 7.0.0 to 7.0.1.
- [Changelog](https://github.com/csstools/postcss-plugins/blob/main/plugins/postcss-logical/CHANGELOG.md)
- [Commits](https://github.com/csstools/postcss-plugins/commits/HEAD/plugins/postcss-logical)

---
updated-dependencies:
- dependency-name: postcss-logical
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump husky from 8.0.3 to 9.0.11 (#2219)

Bumps [husky](https://github.com/typicode/husky) from 8.0.3 to 9.0.11.
- [Release notes](https://github.com/typicode/husky/releases)
- [Commits](typicode/husky@v8.0.3...v9.0.11)

---
updated-dependencies:
- dependency-name: husky
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump spatie/laravel-collection-macros from 7.13.1 to 7.14.1 (#2232)

Bumps [spatie/laravel-collection-macros](https://github.com/spatie/laravel-collection-macros) from 7.13.1 to 7.14.1.
- [Release notes](https://github.com/spatie/laravel-collection-macros/releases)
- [Changelog](https://github.com/spatie/laravel-collection-macros/blob/main/CHANGELOG.md)
- [Commits](spatie/laravel-collection-macros@7.13.1...7.14.1)

---
updated-dependencies:
- dependency-name: spatie/laravel-collection-macros
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump codezero/laravel-unique-translation from 4.2.0 to 4.3.1 (#2211)

chore(deps): bump codezero/laravel-unique-translation

Bumps [codezero/laravel-unique-translation](https://github.com/codezero-be/laravel-unique-translation) from 4.2.0 to 4.3.1.
- [Release notes](https://github.com/codezero-be/laravel-unique-translation/releases)
- [Commits](codezero-be/laravel-unique-translation@4.2.0...4.3.1)

---
updated-dependencies:
- dependency-name: codezero/laravel-unique-translation
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(localization): update translations (#2209)

* chore(localization): translate en.json into French, Canada

* chore(localization): translate en.json into French, Canada

* chore(localization): translate en.json into French, Canada

* chore(localization): translate en.json into French, Canada

* chore(localization): translate en.json into French, Canada

* chore(localization): translate en.json into French, Canada

* chore: replaced single quote with apostrophe in translations

* chore: replace double quote with typographers quotes

* build: 🔧 updated so prettier ignores language files
Prettier will remove  from language files.

* revert: reverted translation of a variable string

---------

Co-authored-by: Marvin Roman <[email protected]>

* chore(release): release 1.4.1 (#2231)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: The Accessibility Exchange <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Justin Obara <[email protected]>
Co-authored-by: CoLab Kube Production V1 <[email protected]>
Co-authored-by: Justin Obara <[email protected]>
Co-authored-by: The Accessibility Exchange <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jobara jobara jobara approved these changes

Assignees

@jobara jobara

Labels
None yet
Projects
Public Launch
Status: Done
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Node ping errors nightly on dev during database reset
2 participants
@marvinroman @jobara