Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: commit message conventions to DEVELOPERS.md #425

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Add: commit message conventions to DEVELOPERS.md #425

merged 1 commit into from
Mar 5, 2024

Conversation

anablaz
Copy link
Contributor

@anablaz anablaz commented Mar 4, 2024

Closes #423

Add the link to the commit message conventions of the Accord project.

Changes

  • Add the link to the commit message conventions of the Accord project.

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname
  • Manual accessibility test performed
    • Keyboard-only access, including forms
    • Contrast at least WCAG Level A
    • Appropriate labels, alt text, and instructions

@anablaz
Add commit message conventions to DEVELOPERS.md
3c99981 
Signed-off-by: anablaz <ab2043@student.uni-lj.si>
mttrbrts
mttrbrts approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@mttrbrts mttrbrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great spot! 🎉

@mttrbrts mttrbrts merged commit b24ce49 into accordproject:main Mar 5, 2024
5 checks passed
@anablaz anablaz deleted the add-commit_message_conventions_link branch March 5, 2024 21:24
Vinyl-Davyl pushed a commit to Vinyl-Davyl/techdocs that referenced this pull request Apr 23, 2024
@anablaz @Vinyl-Davyl
Add commit message conventions to DEVELOPERS.md (accordproject#425)
b8d6509 
Signed-off-by: anablaz <ab2043@student.uni-lj.si>
Signed-off-by: Vinyl-Davyl <okononfuadavid@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mttrbrts mttrbrts mttrbrts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Commit Message Conventions
2 participants
@anablaz @mttrbrts