Insecure connection handling #38
Conversation
|
@achrefbensaad there was issue with the image as changes were not pushed with this tag ,no changes are required in repo. |
|
Please squash before merging |
This reverts commit fa61f4c. Signed-off-by: Rudraksh Pareek <[email protected]>
| {{- if or (or (contains "master" .Values.toolConfig.nodeType) (contains "controlplane" .Values.toolConfig.nodeType)) (or (contains "master" .Values.toolConfig.targets) (contains "controlplane" .Values.toolConfig.targets)) }} | ||
| {{- include "masterConfig" .Values.toolConfig | trim | nindent 10 }} | ||
| {{- end }} |
There was a problem hiding this comment.
Please bring this config back. It is needed for GKE compatibility.
There was a problem hiding this comment.
Remove binary file
There was a problem hiding this comment.
Remove binary file
| {{- if .Values.imagePullSecrets.name }} | ||
| imagePullSecrets: | ||
| - name: {{ .Values.imagePullSecrets.name }} | ||
| {{- end }} | ||
| containers: | ||
| - image: "{{ .Values.accuknoxJob.image.repository }}:{{ .Values.accuknoxJob.image.tag }}" | ||
| - image: accuknox/accuknox-job:latest |
There was a problem hiding this comment.
The configurable image and registry secret is a feature. Please don't remove it.
| valueFrom: | ||
| secretKeyRef: | ||
| key: AUTH_TOKEN | ||
| {{- if (.Values.accuknox.secretName | empty) }} | ||
| name: cis-k8s-job-auth-token | ||
| {{- else }} | ||
| name: {{ .Values.accuknox.secretName }} | ||
| {{- end }} |
There was a problem hiding this comment.
Any reason for removing this?
| - image: "{{ .Values.kubeBench.image.repository }}:{{ .Values.kubeBench.image.tag }}" | ||
| command: | ||
| {{- include "cmd" .Values.toolConfig | trim | nindent 13 }} |
There was a problem hiding this comment.
This is an intended feature. Please don't remove this.
| value: {{ .Values.accuknox.clusterId }} | ||
| value: {{ .Values.accuknox.clusterID }} | ||
| - name: TENANT_ID | ||
| value: {{ .Values.accuknox.tenantId | quote}} | ||
| value: {{ .Values.accuknox.tenantID | quote}} | ||
| - name: URL | ||
| value: {{ .Values.accuknox.url }} | ||
| value: {{ .Values.accuknox.URL }} |
| name: kube-bench | ||
| volumeMounts: | ||
| {{- include "volumeMounts" .Values.toolConfig | trim | nindent 13 }} |
There was a problem hiding this comment.
Intended feature. Please don't remove.
| hostPID: true | ||
| restartPolicy: Never | ||
| volumes: | ||
| {{- include "volumes" .Values.toolConfig | trim | nindent 11 }} |
There was a problem hiding this comment.
Please don't remove this.
| COPY curl_command.sh . | ||
|
|
||
| # Grant execute permissions to the scripts | ||
| RUN chmod +x entrypoint.sh curl_command.sh |
There was a problem hiding this comment.
Remove this RUN step.
On your local system run:
chmod +x entrypoint.sh curl_command.sh
git add entrypoint.sh curl_command.sh
|
PR reverted. PTAL at the added comments and recreate after testing on local. |
No description provided.