Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop utils.dl_models #420

Closed
b1rger opened this issue Nov 14, 2023 · 1 comment · Fixed by #432
Closed

Drop utils.dl_models #420

b1rger opened this issue Nov 14, 2023 · 1 comment · Fixed by #432
Labels
easy Should be an easy fix

Comments

@b1rger
Copy link
Contributor

b1rger commented Nov 14, 2023

The module is not used anywhere in the code and it relies on keras, which is not a dependency of apis-core-rdf

@b1rger b1rger added the easy Should be an easy fix label Nov 14, 2023
harsha-mangena added a commit to harsha-mangena/apis-core-rdf that referenced this issue Nov 16, 2023
- remved `dl_models.py` from utils as it is not used in the source code.
@harsha-mangena
Copy link
Contributor

@b1rger
PR: #421
I have removed the db_models.py from utils

harsha-mangena added a commit to harsha-mangena/apis-core-rdf that referenced this issue Nov 22, 2023
This commit removes the dl_models.py file from the utils directory, as it is no longer in use within our codebase. This cleanup is part of our ongoing efforts to maintain a clean and efficient project structure. By eliminating unused files, we aim to enhance code readability and simplify maintenance. The decision to remove this file was made after a thorough review confirmed its redundancy in our current code implementation.

Closes acdh-oeaw#420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Should be an easy fix
Projects
None yet
2 participants