Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I420-Drop utils.dl_models #421

Conversation

harsha-mangena
Copy link
Contributor

@harsha-mangena harsha-mangena commented Nov 16, 2023

Describe your changes

  • Removed the file dl_models.py from the utils directory, as it is no longer used in the source code.

Additional context

  • The motivation behind this change is to clean up the codebase by removing unused files, which simplifies maintenance and improves code readability.
  • This decision was made after reviewing the current source code and confirming that dl_models.py is indeed not utilized in any part of the project.

Related issues and PRs

Resolves issue:

Supersedes PR:

  • NA

Checklist (Replace the space in square brackets with a lowercase x for all that apply)

  • My changes don't generate new warnings or errors
  • My changes follow the project's code formatting rules and style guidelines
  • I have commented my code with Docstrings and code comments, particularly complex, unusual or hard-to-read code
  • I have updated the project documentation to reflect the changes I introduce
  • I have added new unit tests or updated existing ones to demonstrate my changes works

@b1rger
Copy link
Contributor

b1rger commented Nov 20, 2023

Hi @harsha-mangena , thanks for your contribution. We are using the conventional commits standard for our commit messages, it would be great if you could fix your commit message accordingly. Please also add a Closes: #420 line in the commit message.

thanks,
Birger

@harsha-mangena
Copy link
Contributor Author

Sure, Will fix the commit, Thank for letting me know

@harsha-mangena
Copy link
Contributor Author

@b1rger , Updated the commit message. Kindly let me know If any changes required.

@b1rger
Copy link
Contributor

b1rger commented Nov 22, 2023

@b1rger , Updated the commit message. Kindly let me know If any changes required.

The commit message is still the same, maybe you forgot to push?

This commit removes the dl_models.py file from the utils directory, as it is no longer in use within our codebase. This cleanup is part of our ongoing efforts to maintain a clean and efficient project structure. By eliminating unused files, we aim to enhance code readability and simplify maintenance. The decision to remove this file was made after a thorough review confirmed its redundancy in our current code implementation.

Closes acdh-oeaw#420
@harsha-mangena harsha-mangena force-pushed the remove-unused-utils-harsha branch from 3fdee9b to ec4d872 Compare November 22, 2023 20:45
@harsha-mangena
Copy link
Contributor Author

The commit message has been updated, Kindly check.
image

@b1rger
Copy link
Contributor

b1rger commented Nov 23, 2023

Thanks, I've cleaned up the commit message body (it was way to verbose) and merged the commit. Thanks for your contribution!

@b1rger b1rger closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop utils.dl_models
2 participants