fix(core): fix footer link dimensions

[koeaw]

Set display property of links in site footer
which are visualised by icons – which contain
images or tags for Material Symbols –
to inline-block to make them fit the icons'
dimensions. Prevents links that are smaller
in size than their visual content, which can
cause unexpected behaviour when hovering.

Solves one of the issues described in #1343.

[b1rger]

Can you explain in a bit more detail what this does? "unexpected behaviour when hovering" does not really explain what the problem is.

I tested the PR and I can not see any difference when interacting with the footer elements

[koeaw]

Can you explain in a bit more detail what this does? "unexpected behaviour when hovering" does not really explain what the problem is.

From the issue:

A cursory inspection revealed the links themselves aren't the same size as the icons they surround; I'm assuming this contributes to or is the source of the issue.

When the size and/or positioning of containing and contained elements don't match, spillovers, overlays, offsets or areas without overlap can be the consequence. Users may not necessarily be aware of those until the elements are interacted with.

If a link does not cover the same area as its content, users may end up hovering/clicking/... in the wrong place. When tabbing, the border on the focussed element may look off. Etc.

I can reword the commit message to be more neutral, e.g. change it to "Prevents links that are smaller in size than their visual content, which can cause unexpected behaviour when interacting with them.", but please let's not turn our frontend commits into frontend basics explainers. This commit message is already 3 times the length of the change itself.

[gythaogg]

Changes look good to me.

Perhaps in the commit message you meant "focus" instead of "hover" - that's when I would see a box around the link,

[b1rger]

I'll merge this once I can reproduce the issue

[koeaw]

Changes look good to me.

Thx.

Perhaps in the commit message you meant "focus" instead of "hover" - that's when I would see a box around the link,

I originally noticed on mouse hover – the link destinations would pop up/disappear in areas not 100% consistent with the images. The alternative wording I suggested above would cover any of these without being specific about them.

[koeaw]

Changed the last sentence to (slightly modified from above):
"Prevents links that are smaller different in size than their visual content, which can cause unexpected behaviour when they are interacted with."

[koeaw]

I'll merge this once I can reproduce the issue

Ok.