fix(core): harmonize footer icon dimension specification #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce *one* place to specify dimensions for footer icons in the CSS file by adding an `icon` class to the elements. This replaces the inline `height` settings, the CSS `#logo` definition and overwrites the `height` and `font-size` settings for the material symbol if used in the footer with the icon class. Closes: #1340
b1rger
force-pushed
the
birger/1340-icons
branch
from
795bf8e to
e0850f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce one place to specify dimensions for footer icons in the CSS
file by adding an
iconclass to the elements. This replaces the inlineheightsettings, the CSS#logodefinition and overwrites theheightandfont-sizesettings for the material symbol if used in thefooter with the icon class.
Closes: #1340