birger/1446 template loader list #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The template_list templatetag returns a list of templatenames, based on the MRO of the model passed and a suffix. So instead of hardcoding the `object_table.html` template, we now use this list to look for matching templates, which makes it easier to overload the template. Given that all the models inherit at some point from `genericmodel`, the `object_table.html` template is now being replaced by a `genericmodel_card_table.html` template. Using this template_list approach, it is probably possible to drop some of the templates alltogether and make the template inheritance chain way less complex. Closes: #1446
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
object_table.htmlby template_list lookup