Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

birger/update multiselect #1474

Merged
merged 2 commits into from
Dec 5, 2024
Merged

birger/update multiselect #1474

merged 2 commits into from
Dec 5, 2024

Conversation

b1rger
Copy link
Contributor

@b1rger b1rger commented Dec 4, 2024

  • feat(core): update bootstrap-multiselect dependency
  • feat(core): add additional settings of bootstrap-multiselect

Version 0.9.15 from bootstrap-multiselect was from 2018, the most recent
version 1.1.2 was released in 2022. The old version had a weird
alignment of the selection options, which the new one does not, so we
update the dependency.
This configures the bootstrap-multiselect to enable case insensitive
filtering. It also overrides the default template for the `filter`
input, because in our setup this has some alignment issues.
@b1rger b1rger marked this pull request as ready for review December 4, 2024 09:43
@b1rger b1rger requested a review from gythaogg December 4, 2024 09:44
Copy link
Contributor

@gythaogg gythaogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that case insensitive filtering works where it didn't work before (in the column select of list views, for example).

Unable to see any difference in alignment - if you can guide me on how to test it then this can be merged! Thanks!

My comparisons:
image

image

@b1rger
Copy link
Contributor Author

b1rger commented Dec 5, 2024

Can confirm that case insensitive filtering works where it didn't work before (in the column select of list views, for example).

Unable to see any difference in alignment - if you can guide me on how to test it then this can be merged! Thanks!

There should be a better alignment in the column selector.

This is only about the bootstrap-multiselect library. The screenshots you posted are showing the autocomplete select2 widget, which is not affected by that.

Before:
Screenshot-2024-12-05-093955

After:
Screenshot-2024-12-05-094029

@gythaogg
Copy link
Contributor

gythaogg commented Dec 5, 2024

This is only about the bootstrap-multiselect library. The screenshots you posted are showing the autocomplete select2 widget, which is not affected by that.

Thanks, I'd wrongly assumed that multiselect autocompletes also would get affected...

@b1rger b1rger merged commit 012e1d1 into main Dec 5, 2024
14 checks passed
@b1rger b1rger deleted the birger/update-multiselect branch December 5, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants