fix(apis_entities): disable create_default_uri during fixture loading #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixtures should contain all the data anyway, so the automatic creation of the default uri should be skipped. Closes: #1473
gythaogg
reviewed
Dec 5, 2024
There was a problem hiding this comment.
Potentially we could also use CREATE_DEFAULT_URI = False in settings_loaddata.py? This definitely prevents the (orphan) URI objects from being created by default. Still unsure why URIs when created while importing data are not connected to the entities.
I am just wondering if it's a good idea to shut down the possibility of automatic URI creation when using fixture - when we provide two options to turn them on/off via settings (CREATE_DEFAULT_URI) and data (attribute skip_default_uri).
Just saw #1473 (comment); so let's go with this fix!
gythaogg
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixtures should contain all the data anyway, so the automatic creation
of the default uri should be skipped.
Closes: #1473