fix(generic): select shown columns in column filter #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just saw that this fills in the initial values of the columns correctly, but de-selecting a default column does not remove it |
please note: this is not perfect as the `get_table_class` function gets called twice. Its needed for filtering the kwargs of the table but is not yet available when `get_table_kwargs` gets called. resolves #735
sennierer
force-pushed
the
ms/735-change-`Columns`-field-in-list-filters-to-also-allow-for-deselecting-columns
branch
from
cb48654 to
8610704
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handing through the table class to the filterset might be a more elegant solution than calling the mro resolver again, but given that this is cached anyway its the easier solution.
resolves #735