-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(generic): list all generic models on overview page #921
Conversation
f04cbba
to
3ae12b3
Compare
So, what I find weird about this is that the history models appear under separate, second sections for the apps they belong to, further down the page. I think it would make more sense if they appeared in closer proximity, and under the same section headline. Ideas: the sections could be split in half, with the left side containing the main models, the right side the histories. Or, models and histories could come in pairs? First button links to main models, second to that model's history. I'm trying to think how I'd most likely look up/look for histories, and I think in my head I'd go by model name first, history second, so the idea of button pairs seems like it would take the least amount of time searching for the right button to click on. |
Hmm, also, I see myself opening both the model and its history in parallel , e.g. to check I'm looking at the right object if there are several similar/same-ish named ones (which is the case in Frischmuth), for which the two buttons next to each other would also help. |
Can you create a screenshot? The PR only splits the models by the app they belong to and the versions are part of the same app, so they should be part of the same section |
Hm, interesting, thats not how it should look |
3ae12b3
to
413fc66
Compare
Thats fixed now |
This commit introduces the templatetag `genericmodel_content_types` which lists all content types of models that inherit from `apis_core.generic.abc.GenericModel`. This templatetag is then used in the overview template to create an overview of *all* those contenttypes and not only `apis_ontology` and `collections` as it was hardcoded before. Closes: #912
This commit introduces the templatetag
genericmodel_content_types
which lists all content types of models that inherit from
apis_core.generic.abc.GenericModel
. This templatetag is then usedin the overview template to create an overview of all those
contenttypes and not only
apis_ontology
andcollections
as it washardcoded beofre.
Closes: #912