Skip to content

Commit

Permalink
refactor(api): rename custom ModelSerializers
Browse files Browse the repository at this point in the history
Rename ModelSerializers used for custom endpoints
to avoid clashes with default generic serializers for
entities defined in apis_core/api_routers.py.
(Swagger UI generates warnings on identically named
Serializers; Django REST framework api view remains
unaffected.)
  • Loading branch information
koeaw committed Apr 29, 2024
1 parent aecc36e commit 2b41e46
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions apis_ontology/api/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from apis_ontology.models import Expression, Work, WorkType


class WorkTypeSerializer(serializers.ModelSerializer):
class WorkTypeDataSerializer(serializers.ModelSerializer):
class Meta:
model = WorkType
fields = [
Expand All @@ -17,7 +17,7 @@ class Meta:
]


class ExpressionSerializer(serializers.ModelSerializer):
class ExpressionDataSerializer(serializers.ModelSerializer):
publication_date = serializers.DateField(required=False, allow_null=True)
publisher = serializers.CharField(required=False, allow_null=True)
place_of_publication = serializers.ListField(
Expand All @@ -39,8 +39,8 @@ class Meta:


class WorkPreviewSerializer(serializers.ModelSerializer):
expression_data = ExpressionSerializer(required=False, many=True)
work_type = WorkTypeSerializer(required=False)
expression_data = ExpressionDataSerializer(required=False, many=True)
work_type = WorkTypeDataSerializer(required=False)

class Meta:
model = Work
Expand Down

0 comments on commit 2b41e46

Please sign in to comment.