Refactor filtersets (inheritance, purpose of classes), restore custom search fields #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differentiate between entity model-based FilterSets and (reusable) classes for custom search fields: Have the former inherit directly from a common parent which inherits from AbstractEntityFilterSet, rename the latter for clarity, add Docstrings, have them inherit from django_filters base FilterSet.
Rename custom search fields so they don't clash/aren't overwritten by new APIS Core search field which filters across a model's (built-in) string fields (CharField, TextField).
Move filter_overrides for ArrayField to Meta class of common parent for model-based FilterSets to reduce redundancy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.