RDF imports: remove redundant code, fix ref, add DOB/DOD for Persons #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The classes in importers.py were inheriting from a non-existent parent class in APIS Core, but are superfluous (didn't to anything different from GenericModelImporter).
Fix name of class which inherits from ExternalAutocomplete helper for Organisation entity so GenericModelImporter knows which entity to match any .toml file superclass definitions to.
Rename .toml files for importing Organisation data to match name of entity.
|
Thanks for your contribution! |
koeaw
force-pushed
the
kk/feat/rdfimport
branch
from
103af67 to
071436c
Compare
Include dateOfBirth, dateOfDeath in 'format' parameter in LobidAutocompleteAdapter for Persons.
koeaw
force-pushed
the
kk/feat/rdfimport
branch
from
071436c to
ef0ccf5
Compare
|
Merging this after f2f chat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.