Improve filters #196
Merged
Improve filters #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koeaw
force-pushed
the
kk/feat/filters
branch
from
4682d88 to
d6166a8
Compare
In BaseEntityFilterSet, remove 'notes' field from excluded fields inherited from AbstractEntityFilterSet so the ontology-specific 'notes' field (included in many entities via NotesMixin) shows up in filters.
Remove redundant filterable field + lookup declarations from Meta classes which repeat filters declared directly on fields (which will thus be ignored).
Adapt custom search filter labels and help_texts to be consistent with generic search field. Importantly, spell out model fields covered by each custom search field for clarity.
koeaw
force-pushed
the
kk/feat/filters
branch
3 times, most recently
from
e17ed4c to
c8d07f4
Compare
Replace English (lead-ins of) help_texts of filters inherited from AbstractEntityFilterSet with German wordings. Applies to 'changed_since' and generic 'search' fields specifically.
koeaw
force-pushed
the
kk/feat/filters
branch
from
c8d07f4 to
eabeadb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notesfieldMetadeclarationslabels,help_textsfor consistency