Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump apis-acdhch-default-settings to v1.1.1 #199

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

b1rger
Copy link
Contributor

@b1rger b1rger commented Sep 19, 2024

apis-core v0.26.0 changes how menu items are added to the relations
menu: the items are not hardcoded in the base.html template, but the
apps are responsible for overriding the base.html template and adding
them. therefore the order the apps are listed in INSTALLED_APPS is
important. apis-acdhch-default-settings v1.1.1 changes this order.
See commit 5f27f04146228d255a9e46dd53bb36e9947542a2 in the apis-core
repository.

apis-core v0.26.0 changes how menu items are added to the relations
menu: the items are not hardcoded in the `base.html` template, but the
apps are responsible for overriding the `base.html` template and adding
them. therefore the order the apps are listed in INSTALLED_APPS is
important. apis-acdhch-default-settings v1.1.1 changes this order.
See commit 5f27f04146228d255a9e46dd53bb36e9947542a2 in the apis-core
repository.
@b1rger b1rger marked this pull request as ready for review September 19, 2024 08:24
@koeaw
Copy link
Collaborator

koeaw commented Sep 19, 2024

Ah, thank you, I didn't catch that when testing v0.26.0.

@koeaw koeaw merged commit 24917fa into deploy Sep 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants