Rename Expression publication date fields, update verbose names, help text #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename field for manual input of Expression publication date from publication_date to publication_date_manual_input to reduce ambiguity between the two fields used for storing the date (one for manual input/imported data, one for parsed/converted ISO date).
Change field name from publication_date_iso to publication_date_iso_formatted to make its purpose even clearer. (It does not simply hold an ISO date, it holds an ISO-formatted version of the other date.)
Update verbose_name attribute of both Expression publication date fields; remove redundant help_text for ISO-formatted date field (field is set to uneditable).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the two fields use for storing an
Expressions publication date (manual input + ISO-formatted) to make it easier to differentiate them/to remove ambiguity.