Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

birger/alternative names new #395

Merged
merged 3 commits into from
Dec 11, 2024
Merged

birger/alternative names new #395

merged 3 commits into from
Dec 11, 2024

Conversation

b1rger
Copy link
Contributor

@b1rger b1rger commented Dec 6, 2024

  • chore(deps): add django-json-editor-field to dependencies
  • feat(settings): add django_json_editor_field to INSTALLED_APPS
  • feat(models): add alternative_names_new field using the JSONEditorField

@b1rger b1rger force-pushed the birger/alternative-names-new branch 4 times, most recently from a084e54 to 447a8cc Compare December 10, 2024 09:44
@b1rger b1rger marked this pull request as ready for review December 10, 2024 10:54
@b1rger b1rger requested a review from sennierer December 10, 2024 10:54
@b1rger b1rger force-pushed the birger/alternative-names-new branch 2 times, most recently from 52aae7d to 674826d Compare December 10, 2024 11:01
Copy link
Collaborator

@sennierer sennierer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installed a new db, imported the data, migrated the field. Everything was copied over correctly and the forms work just perfect.

@b1rger b1rger force-pushed the birger/alternative-names-new branch from 674826d to b12b362 Compare December 11, 2024 10:33
@b1rger b1rger merged commit 36b6003 into main Dec 11, 2024
4 checks passed
@b1rger b1rger deleted the birger/alternative-names-new branch December 11, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants