fix: adjust existing code to satisfy updated acdh-ch linter rules

app/[locale]/(index)/page.tsx

@@ -1,5 +1,5 @@
 import type { Metadata, ResolvingMetadata } from "next";
-import { getTranslations, unstable_setRequestLocale as setRequestLocale } from "next-intl/server";
+import { getTranslations, setRequestLocale } from "next-intl/server";
 
 import { MainContent } from "@/components/main-content";
 import { PublicationGrid } from "@/components/publication-grid";
@@ -48,7 +48,7 @@ export default async function IndexPage(props: IndexPageProps) {
 		// TODO workaround until upgrade to typesense 0.28, afterwards can just use: "_rand:asc"
 		// just look for a single random letter a-w (ASCII 65-87)
 		q: String.fromCharCode(Math.floor(65 + 22 * Math.random())),
-		sort_by: "_text_match:" + (Math.random() > 0.5 ? "asc" : "desc"),
+		sort_by: `_text_match:${Math.random() > 0.5 ? "asc" : "desc"}`,
 	});
 	return (
 		<MainContent>

app/[locale]/imprint/page.tsx

@@ -2,7 +2,7 @@ import { HttpError, request } from "@acdh-oeaw/lib";
 import type { Metadata, ResolvingMetadata } from "next";
 import { notFound } from "next/navigation";
 import { useTranslations } from "next-intl";
-import { getTranslations, unstable_setRequestLocale as setRequestLocale } from "next-intl/server";
+import { getTranslations, setRequestLocale } from "next-intl/server";
 import type { ReactNode } from "react";
 
 import { MainContent } from "@/components/main-content";

app/[locale]/internal-error.tsx

@@ -12,6 +12,7 @@ interface InternalErrorProps {
 }
 
 /** `React.lazy` requires default export. */
+// eslint-disable-next-line import-x/no-default-export
 export default function InternalError(props: InternalErrorProps): ReactNode {
 	const { error, reset } = props;
 

app/[locale]/layout.tsx

@@ -2,7 +2,7 @@ import { pick } from "@acdh-oeaw/lib";
 import { cn } from "@acdh-oeaw/style-variants";
 import type { Metadata, ResolvingMetadata } from "next";
 import { useMessages, useTranslations } from "next-intl";
-import { getTranslations, unstable_setRequestLocale as setRequestLocale } from "next-intl/server";
+import { getTranslations, setRequestLocale } from "next-intl/server";
 import type { ReactNode } from "react";
 import { LocalizedStringProvider as Translations } from "react-aria-components/i18n";
 import { jsonLdScriptProps } from "react-schemaorg";

components/disclosure-button.tsx

@@ -19,6 +19,7 @@ export function DisclosureButton(props: DisclosureButtonProps): ReactNode {
 			aria-expanded={props.state}
 			className={className}
 			onClick={() => {
+				// eslint-disable-next-line @typescript-eslint/no-unsafe-call
 				props.setState(true);
 			}}
 			type="button"

components/instantsearch/sortby.tsx

@@ -20,6 +20,7 @@ function SortIcon(props: { field: string | undefined; size: number }): ReactNode
 			return <CalendarArrowDown size={props.size} />;
 		case "title:asc":
 			return <ArrowDownAZ size={props.size} />;
+		case undefined:
 		default:
 			return <ArrowDownUp size={props.size} />;
 	}

components/ui/select.tsx

@@ -14,7 +14,6 @@ import {
 	type ListBoxProps as AriaListBoxProps,
 	Popover as AriaPopover,
 	type PopoverProps as AriaPopoverProps,
-	Section as AriaSection,
 	Select as AriaSelect,
 	SelectValue as AriaSelectValue,
 	type SelectValueProps as AriaSelectValueProps,
@@ -24,8 +23,6 @@ import {
 
 export const Select = AriaSelect;
 
-export const SelectSection = AriaSection;
-
 export const SelectCollection = AriaCollection;
 
 export function SelectValue<T extends object>({

e2e/tests/app/metadata.test.ts

@@ -119,7 +119,7 @@ test("should serve an open-graph image", async ({ createIndexPage, request }) =>
 		await expect(indexPage.page.locator('meta[property="og:image"]')).toHaveAttribute(
 			"content",
 			expect.stringContaining(
-				String(createUrl({ baseUrl: env.NEXT_PUBLIC_APP_BASE_URL, pathname: imagePath })) + `?`,
+				`${createUrl({ baseUrl: env.NEXT_PUBLIC_APP_BASE_URL, pathname: imagePath })}?`,
 			),
 		);
 

lib/analytics-script.tsx

@@ -32,7 +32,7 @@ export function AnalyticsScript(props: AnalyticsProps): ReactNode {
 		<Fragment>
 			<Script
 				dangerouslySetInnerHTML={{
-					__html: `(${String(createAnalyticsScript)})("${baseUrl.endsWith("/") ? baseUrl : baseUrl + "/"}", "${String(id)}");`,
+					__html: `(${String(createAnalyticsScript)})("${baseUrl.endsWith("/") ? baseUrl : `${baseUrl}/`}", "${String(id)}");`,
 				}}
 				id="analytics-script"
 			/>
@@ -48,13 +48,13 @@ function createAnalyticsScript(baseUrl: string, id: number): void {
 	_paq.push(["disableCookies"]);
 	_paq.push(["enableHeartBeatTimer"]);
 	const u = baseUrl;
-	_paq.push(["setTrackerUrl", u + "matomo.php"]);
+	_paq.push(["setTrackerUrl", `${u}matomo.php`]);
 	_paq.push(["setSiteId", id]);
 	const d = document,
 		g = d.createElement("script"),
 		s = d.getElementsByTagName("script")[0];
 	g.async = true;
-	g.src = u + "matomo.js";
+	g.src = `${u}matomo.js`;
 	s?.parentNode?.insertBefore(g, s);
 }
 

lib/i18n.ts

@@ -5,6 +5,7 @@ import { getRequestConfig } from "next-intl/server";
 
 import { isValidLocale } from "@/config/i18n.config";
 
+// eslint-disable-next-line @typescript-eslint/no-deprecated
 export default getRequestConfig(async ({ locale }) => {
 	if (!isValidLocale(locale)) notFound();
 

lib/navigation.ts

@@ -8,6 +8,7 @@ const {
 	redirect: _redirect,
 	usePathname,
 	useRouter,
+	// eslint-disable-next-line @typescript-eslint/no-deprecated
 } = createSharedPathnamesNavigation({
 	locales,
 });

styles/index.css

@@ -138,7 +138,6 @@ textarea {
 	margin-inline: auto;
 	padding-inline: theme("padding.4");
 
-	/* stylelint-disable-next-line media-query-no-invalid */
 	@media screen("md") {
 		padding-inline: theme("padding.8");
 	}