Skip to content

Commit

Permalink
fix(package): Fixed error venv instantiation.
Browse files Browse the repository at this point in the history
It had the wrong location.
Removed ``container_name`` from ``compose.yaml`` since it matches the
provided name.
  • Loading branch information
acederberg committed Aug 19, 2024
1 parent c81b545 commit 8148f1a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/commit_checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,12 @@ jobs:
- name: Checkout.
uses: actions/checkout@v4

# NOTE: ``mkdir`` step is required for propper permissions on ~/.venv.
# NOTE: ``mkdir`` step is required for propper permissions on ``~/.venv``
# (not used here).
#
# Use ``docker compose --file docker/compose.yaml config | less``
# to see the config with interpolated variables from ``.env``.
# More about interpolation: https://docs.docker.com/compose/environment-variables/variable-interpolation/
# More about interpolation: https://docs.docker.com/compose/environment-variables/variable-interpolation/
- name: Setup.
run: |
mkdir --parent docker/.venv
Expand All @@ -134,7 +136,7 @@ jobs:
docker compose \
--file docker/compose.yaml \
exec server \
bash -c "python -m venv .venv"
bash -c "python -m venv ~/.venv"
# NOTE: ``act.yaml`` defined everything necessary for the client and server.
- name: Install Dependencies In Server.
Expand Down
4 changes: 2 additions & 2 deletions docker/compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ services:
CAPTURA_FLAKEY: "${CAPTURA_FLAKEY-/home/captura/app/config/flakey.yaml}"
CAPTURA_PLUGINS_USE: "${CAPTURA_PLUGINS_USE-0}"
image: acederberg/captura-development:0.1.5
container_name: captura-server
# container_name: captura-server
ports:
- target: 8080
published: 8080
Expand All @@ -31,7 +31,7 @@ services:
- /home/captura/app/docker/.venv
db:
image: mysql:8
container_name: captura-db
# container_name: captura-db
environment:
MYSQL_RANDOM_ROOT_PASSWORD: 1
MYSQL_DATABASE: captura
Expand Down

0 comments on commit 8148f1a

Please sign in to comment.