Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio - Add Radio broadcast sounds #148

Open
wants to merge 12 commits into
base: experimental
Choose a base branch
from
Open

Conversation

veteran29
Copy link
Member

When merged this pull request will:

  • title
  • Sounds are from ACRE2

Converted from ArmaForces/Mods_AR#3 to ACE:

2024-12-23_00-58-13_-_Trim.mp4

image

@veteran29 veteran29 added the kind/feature Release Notes: **ADDED:** label Jan 4, 2025
@Kexanone
Copy link
Member

Kexanone commented Jan 4, 2025

ACE UI seems a bit too broad for a mod name. Maybe something like ACE Radio is more suitable.

@Kexanone Kexanone changed the title UI - Add Radio broadcast sounds Radio - Add Radio broadcast sounds Feb 12, 2025
@Kexanone Kexanone changed the base branch from master to experimental February 12, 2025 21:04
@Kexanone Kexanone added this to the 1.3.0 milestone Feb 12, 2025
@Kexanone Kexanone added the 1.3.0.x Arma Reforger version 1.3.0.x label Feb 12, 2025
@Kexanone
Copy link
Member

I changed the prefix and updated for experimental WB

Copy link
Member

@Kexanone Kexanone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably think about how to handle higher channels like 3 and 4, as these are also common when you have the long range radio backpack equipped.

Comment on lines +1 to +6
enum ACE_ERadioBeep
{
OFF = 1 << 0,
NORMAL = 1 << 1,
LOW = 1 << 2,
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
enum ACE_ERadioBeep
{
OFF = 1 << 0,
NORMAL = 1 << 1,
LOW = 1 << 2,
}
[EnumBitFlag()]
enum ACE_ERadioBeep
{
OFF,
NORMAL,
LOW,
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.3.0.x Arma Reforger version 1.3.0.x kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants