-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wardrobe - New Addon - System to modify wearables #10606
Open
OverlordZorn
wants to merge
120
commits into
acemod:master
Choose a base branch
from
OverlordZorn:ace-wardrobe
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rautamiekka
suggested changes
Dec 27, 2024
OverlordZorn
changed the title
Wardrobe - New: System to modify current wearables
Wardrobe - New Addon - System to modify wearables
Dec 28, 2024
rautamiekka
suggested changes
Dec 30, 2024
Co-authored-by: Jouni Järvinen <[email protected]>
Co-authored-by: Jouni Järvinen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
When merged this pull request will:
Introduces a new system to modify currently worn gear.
For Example:
UX:
Compats for: GM, SOG, WS, RF
To Do:
- Rework the sound part to work with thesound_timing
property.- Rework the System to work with thecomponents[]
property.-- Defines the components of an Items. For example: Dustglasses.If it changes from an item with components to an item without the same components, it will deposit these components into the players inventory or vis versa, when changing to an item that requiers an component which the currently worn doesnt have, it needs to be in the inventory and will be removed when changed into.
-- Check for components is done, just need to return/remove components from/to the inventory.- Fix the formating of the configs so the checks dont fail?- Add more compats for the cdlc/vanilla stuff utilizing the component feature. (example: blk balaclava -> blk balaclava with eye protectors)- Find better default soundsBugs:
- RF Altin Helmets: Seems like the helmet without any visor can be modified into a visor-version.Looks like it inherits wardrobe data?
IMPORTANT
⌚ If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
❓ Development Guidelines are read, understood and applied.
✔️ Title of this PR uses our standard template
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.