Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wardrobe - New Addon - System to modify wearables #10606

Open
wants to merge 120 commits into
base: master
Choose a base branch
from

Conversation

OverlordZorn
Copy link
Contributor

@OverlordZorn OverlordZorn commented Dec 27, 2024

WIP

When merged this pull request will:

  • New Addon: Wardrobe
    Introduces a new system to modify currently worn gear.

For Example:

  • Roll up/down your sleeves.
  • Raise or lower the visor of helmets.
  • Modify turbans from to the other variants.
  • Combat Goggles <-> Balaclava with Combat Goggles <-> Balaclava

UX:

  • ACE Self Interaction -> Equipment -> Wardrobe (if modifiable Item)
  • Inventory -> CBA Context Menu on Wearable Slot

Compats for: GM, SOG, WS, RF

To Do:

- Rework the sound part to work with the sound_timing property.
- Rework the System to work with the components[] property.
-- Defines the components of an Items. For example: Dustglasses.
If it changes from an item with components to an item without the same components, it will deposit these components into the players inventory or vis versa, when changing to an item that requiers an component which the currently worn doesnt have, it needs to be in the inventory and will be removed when changed into.

-- Check for components is done, just need to return/remove components from/to the inventory.
- Fix the formating of the configs so the checks dont fail?
- Add more compats for the cdlc/vanilla stuff utilizing the component feature. (example: blk balaclava -> blk balaclava with eye protectors)
- Find better default sounds

  • remove test mission from PR
  • Do the Documentation thingy

Bugs:

- RF Altin Helmets: Seems like the helmet without any visor can be modified into a visor-version.
Looks like it inherits wardrobe data?

IMPORTANT

⌚ If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.

Development Guidelines are read, understood and applied.

✔️ Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

addons/wardrobe/TODO/gm/Uniforms.hpp Outdated Show resolved Hide resolved
addons/wardrobe/TODO/rf/Uniforms.hpp Outdated Show resolved Hide resolved
addons/wardrobe/TODO/vn/Pilothelmets.hpp Outdated Show resolved Hide resolved
addons/wardrobe/TODO/vn/Uniforms_B.hpp Outdated Show resolved Hide resolved
addons/wardrobe/script_macros_zrn.hpp Outdated Show resolved Hide resolved
@OverlordZorn OverlordZorn changed the title Wardrobe - New: System to modify current wearables Wardrobe - New Addon - System to modify wearables Dec 28, 2024
@LinkIsGrim LinkIsGrim self-assigned this Dec 31, 2024
@LinkIsGrim LinkIsGrim added the kind/feature Release Notes: **ADDED:** label Dec 31, 2024
@LinkIsGrim LinkIsGrim added this to the Ongoing milestone Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants