-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nametags - Fix overlapping draw order #10680
base: master
Are you sure you want to change the base?
Conversation
Why it should be toggable setting? |
Yeah I don't really see the point of the setting here, this is an improvement and I can't imagine anyone would want overlapping when they have the option not to. |
Co-authored-by: Jouni Järvinen <[email protected]>
I had it as a setting as it technically comes with a 18% performance penalty over the previous one which could add up since its running on most drawn frames. |
Can't we just do a |
Removed the option and utilized |
When merged this pull request will:
Screenshot of before vs after
Performance comparison:
private _nearMenOld = (positionCameraToWorld [0, 0, 0]) nearObjects ["CAManBase", 5 + 7];
private _nearMen = nearestObjects [(positionCameraToWorld [0, 0, 0]), ["CAManBase"], 5 + 7]; reverse _nearMen;