Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle custom ios identifiers #117

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Conversation

achorein
Copy link
Owner

@achorein achorein commented Sep 23, 2024

Summary

"plugins": [
      [
        "expo-share-intent",
        {
          // default `group.${appIdentifier}`
          "iosAppGroupIdentifier": "group.expo.modules.exposhareintent.custom",
          // default "ShareExtension"
          "iosShareExtensionName": "My Super Share Extension",
        }
      ],
    ],

Todo

  • Allow to set Application Group Identifier for share extension
  • Allow to change Extension Bundle Identifier
  • Update README.md

Issue

Fixes #94
Fixes #88

@achorein achorein force-pushed the feat/custom-ios-identifiers branch 3 times, most recently from 7defb92 to 1c52f76 Compare October 8, 2024 15:46
@achorein achorein force-pushed the feat/custom-ios-identifiers branch from 1c52f76 to 3cd6ae7 Compare October 16, 2024 15:31
@achorein achorein marked this pull request as ready for review October 16, 2024 15:32
@achorein achorein force-pushed the feat/custom-ios-identifiers branch from 20a83db to 9b17bf2 Compare December 6, 2024 12:30
@achorein achorein force-pushed the feat/custom-ios-identifiers branch from 4403760 to 006cb6f Compare December 9, 2024 19:09
@achorein achorein merged commit 107225c into main Dec 9, 2024
4 checks passed
@achorein achorein deleted the feat/custom-ios-identifiers branch December 9, 2024 19:14
achorein added a commit that referenced this pull request Dec 9, 2024
achorein added a commit that referenced this pull request Dec 9, 2024
* feat: handle custom ios identifiers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow custom application group identifier Can we change bundle identifer for ios extension
1 participant