fix: ios - ensure the target is not added to main project multiple times (during prebuild) #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achorein
changed the title
…s during prebuild
achorein
force-pushed
the
fix-do-not-add-target-multiple-times
branch
from
682c8c9 to
f84eb1d
Compare
|
@Kasendwa thanks for you help on this 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Every time I run
npx expo prebuild, a duplicate target is added on the xcode main project. This is wrong and causes build failures.This PR adds checks to skip the process if the target was previously added to the main project.