Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add disabled option #30

Merged
merged 5 commits into from
Mar 21, 2024
Merged

feat: add disabled option #30

merged 5 commits into from
Mar 21, 2024

Conversation

achorein
Copy link
Owner

@achorein achorein commented Mar 18, 2024

Summary

Allow to disable share intent module (native call) and open the app in expo go environment for speed testing (without dev-client).

useShareIntent({ disabled: true });
<ShareIntentProvider options={{ disabled: true }}><App/></ShareIntentProvider>;

Todo

  • Add disabled option
  • Add debug log
  • Update README.md

Issue

#23

Test

With normal dev-client build (run:ios)

  • disabled=true (iOS)
  • disabled=false (iOS)
  • disabled=true (Android)
  • disabled=false (Android)

With expo-go (start:ios)

  • disabled=true (iOS)
  • disabled=true (Android)

@achorein achorein force-pushed the feat/disabled-option branch 3 times, most recently from 1df2c35 to 0cc7146 Compare March 21, 2024 15:25
@achorein achorein force-pushed the feat/disabled-option branch from 2b94a3a to 97f11a4 Compare March 21, 2024 15:33
@achorein achorein merged commit d4e45aa into main Mar 21, 2024
4 checks passed
@achorein achorein deleted the feat/disabled-option branch March 21, 2024 15:35
achorein added a commit that referenced this pull request Mar 21, 2024
* feat: add disabled option

* add debug log

* disable resetShareIntent as well

* update README

* fix example dependancies
achorein added a commit that referenced this pull request Mar 21, 2024
* feat: add disabled option

* add debug log

* disable resetShareIntent as well

* update README

* fix example dependancies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant