Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: retreive file mimeType from iOS #41

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Conversation

achorein
Copy link
Owner

@achorein achorein commented Apr 7, 2024

Summary

In order to have the same file description on iOS and Android, we need to get the mimeType from the iOS part.

export interface IosShareIntentFile {
  path: string;
  type: string;
  fileName: string;
  mimeType: string;
}

export interface AndroidShareIntentFile {
  fileName: string;
  filePath: string;
  mimeType: string;
  contentUri: string;
}

Todo

  • Retrieve file mimeType from file extension on iOS
  • Harmonize shareIntent.type for ios and android
  • Update README.md

Issue

#40

Base automatically changed from fix/ios-sharetextension-displayerror to main April 7, 2024 17:07
@achorein achorein force-pushed the feat/ios-file-mimeType branch from a98d683 to a56c413 Compare April 7, 2024 17:07
@achorein achorein merged commit ac5fa24 into main Apr 7, 2024
4 checks passed
@achorein achorein deleted the feat/ios-file-mimeType branch April 7, 2024 17:09
achorein added a commit that referenced this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant