fix(typescript): ensure that eslint recommended overrides are applied

ackama · Dec 2, 2024 · ac8adf8 · ac8adf8
1 parent 790edd6
commit ac8adf8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/types.d.ts b/types.d.ts
@@ -96,7 +96,8 @@ declare module '@typescript-eslint/eslint-plugin' {
       'all': ESLint.Linter.LegacyConfig;
       'base': ESLint.Linter.LegacyConfig;
       'disable-type-checked': ESLint.Linter.LegacyConfig;
-      'eslint-recommended': ESLint.Linter.LegacyConfig;
+      'eslint-recommended': ESLint.Linter.LegacyConfig &
+        Required<Pick<ESLint.Linter.LegacyConfig, 'overrides'>>;
       'recommended': ESLint.Linter.LegacyConfig;
       /** @deprecated - please use "recommended-type-checked" instead. */
       'recommended-requiring-type-checking': ESLint.Linter.LegacyConfig;

diff --git a/typescript.js b/typescript.js
@@ -175,6 +175,11 @@ const generateConfig = () => {
           'prettier': pluginPrettier
         },
         rules: {
+          // we have to manually include this in flat config due to @typescript-eslint
+          // expecting a special helper package to be used to translate their configs
+          // which we're choosing not to use, at least for now
+          ...pluginTypeScriptESLint.configs['eslint-recommended'].overrides[0]
+            .rules,
           ...pluginTypeScriptESLint.configs['recommended-type-checked'].rules,
           ...pluginTypeScriptESLint.configs['stylistic-type-checked'].rules,
           ...pluginPrettierRecommended.rules,