Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistence Fix [SchoolData] #43

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Persistence Fix [SchoolData] #43

wants to merge 2 commits into from

Conversation

sakrifor
Copy link
Contributor

This PR mainly fixes a bug with persistence of SchoolData.

  • Changed the json serialization method of SchoolData class
  • User icon is now an asset rather than a NetworkImage

Tested:
Opened the app and when fully loaded and disabled internet access. Closed and reopened the app. Information displayed as usual.

Future things to consider:

  • Notification that there is no internet access
  • Disable editable items (e.g. Edit Profile)

sakrifor
sakrifor commented May 27, 2021
View reviewed changes
Copy link
Contributor Author

@sakrifor sakrifor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me! 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sakrifor