Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache optimised update 1 #8

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lithium-anode
Copy link

No description provided.

@bunsamosa-bot
Copy link

bunsamosa-bot bot commented Oct 19, 2024

Thank you from Opening this Pull Request, @lithium-anode ! A Maintainer will review it soon!

@lithium-anode
Copy link
Author

I noticed a parameter error in my code and so i pushed a new commit "cache optimised update 2"

@lithium-anode
Copy link
Author

@Icarus131 can you please review the most recent commit i pushed

@Icarus131
Copy link
Collaborator

check the performance diff again, looks like it is a negative change

@lithium-anode
Copy link
Author

check the performance diff again, looks like it is a negative change

alright, i'll look into it

@lithium-anode
Copy link
Author

i have pushed the new commit with the corrected code. the optimised code performs faster

@lithium-anode
Copy link
Author

@Icarus131 please review this code and let me know if there are any changes i should make

@lithium-anode
Copy link
Author

Screenshot 2024-10-19 at 7 00 02 AM

@lithium-anode
Copy link
Author

Screenshot 2024-10-19 at 7 00 34 AM

@lithium-anode
Copy link
Author

@Icarus131 , I pushed a new commit which uses cache from functools. Im also attaching the output screenshots. i ran the code 10 times and i got a decrease in time in majority of these cases. can you please review this-

output_screenshots.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants