-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend - Hookup application #57
Conversation
Turns out the backend does a lot of strict validation oof
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, two minor comments 🫡
Interestingly I get the login bug here but only for /dashboard and not /apply, I'll look into what's happening
client/src/lib/types/application.ts
Outdated
interests: string[]; | ||
major: string; | ||
referrer: string[]; | ||
// TODO: upload and save resumes to s3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove this comment
client/src/config.tsx
Outdated
@@ -192,13 +190,13 @@ export const appQuestions: Step[] = [ | |||
}, | |||
{ | |||
type: 'file', | |||
id: 'resume', | |||
id: 'resumeLink', | |||
question: <>Upload your resume in PDF format below (Max: 100MB).</>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think max is 2MB
also: do we do any client-side validation? Let's tell them it's .pdf, .docx, .doc only and hopefully be able to check on the client for them as well
/apply directs to /apply/1. Maybe this redirect allows it to apply the cookie? not sure. Though also, /apply isn't affected by the middleware (i.e. it'll redirect to /apply/1 first before checking if you're logged in) |
Info
Closes #23
Description
What changes did you make? List all distinct problems that this PR addresses. Explain any relevant
motivation or context.
Because the backend cannot store partial applications, the application draft is stored locally on the device, and may get lost when e.g. iOS Safari does its daily site data clearing. Each application step will store the user's potentially invalid responses locally (using IndexedDB), then on the review page, clicking "Submit" will actually create an application on the backend. Currently, users cannot edit their applications after submitting.
Changes
/apply/[step]
instead of/apply/?step=[step]
because apparently getting url params is a client-only featureType of Change
expected)
workflows, linting, etc.)
If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in
package.json
!Testing
I have tested that my changes fully resolve the linked issue ...
To reset my application, I've been changing
getApplication
on line 31 of [step]/page.tsx todeleteApplication
, then going to /apply/1 a few times.Checklist
package.json
file.Screenshots