Fixed feedback from Sean

acmucsd · Jan 8, 2025 · 5977c0a · 5977c0a
1 parent ab5d2ef
commit 5977c0a
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 29 deletions.
diff --git a/src/components/common/VerticalFormItem/index.tsx b/src/components/common/VerticalFormItem/index.tsx
@@ -1,7 +1,7 @@
 import React, { HTMLInputTypeAttribute, ReactNode, useState } from 'react';
 import { UseFormRegisterReturn, useForm } from 'react-hook-form';
 import styles from './style.module.scss';
-
+import { AiOutlineSearch } from 'react-icons/ai';
 interface InputTypeProps {
   element: 'input';
   type: HTMLInputTypeAttribute;
@@ -97,13 +97,13 @@ const VerticalFormItem = (props: VerticalFormProps) => {
     return (
       <div className={styles.formItem}>
         <div className={styles.formInput}>
-          <div className={styles.iconContainer}>{icon}</div>
+          <div className={styles.iconContainer}>{<AiOutlineSearch />}</div>
           <div>
             <h1>Selected: {selectedOptions.join(', ')}</h1>
             <div>
               <input
                 type="text"
-                placeholder="Search..."
+                placeholder="Click to search"
                 value={searchTerm}
                 onChange={e => setSearchTerm(e.target.value)}
                 className={styles.inputField}
@@ -119,9 +119,9 @@ const VerticalFormItem = (props: VerticalFormProps) => {
                 onChange={handleSelectionChange}
                 // {...formRegister}
               >
-                <option value="" disabled>
+                {/* <option value="" disabled>
                   {placeholder}
-                </option>
+                </option> */}
                 {filteredOptions.map(value => (
                   <option key={value}>{value}</option>
                 ))}
@@ -133,20 +133,7 @@ const VerticalFormItem = (props: VerticalFormProps) => {
       </div>
     );
   }
-  // if (element === 'select-multiple') {
-  //   const { options } = props;
-  //   const [searchTerm, setSearchTerm] = useState('');
-  //   const [filteredOptions, setFilteredOptions] = useState(options);
-
-  //   useEffect(() => {
-  //     setFilteredOptions(options.filter(option => option.toLowerCase().includes(searchTerm.toLowerCase())));
-  //   }, [searchTerm, options]);
 
-  //   const handleSelectionChange = (event, field) => {
-  //     const selectedValues = Array.from(event.target.selectedOptions, option => option.value);
-  //     setValue()
-  //   }
-  // }
   return null;
 };
 

diff --git a/src/pages/admin/attendance.tsx b/src/pages/admin/attendance.tsx
@@ -10,8 +10,7 @@ import withAccessType, { GetServerSidePropsWithAuth } from '@/lib/hoc/withAccess
 import type { NextPage } from 'next';
 import { AdminAPI, EventAPI } from '@/lib/api';
 import { SubmitHandler, useForm } from 'react-hook-form';
-import { AiOutlineArrowDown } from 'react-icons/ai';
-import {} from 'react-icons/vsc';
+import { AiOutlineArrowDown, AiOutlineCalendar } from 'react-icons/ai';
 import { PublicEvent } from '@/lib/types/apiResponses';
 
 interface FormValues {
@@ -47,7 +46,7 @@ const AwardPointsPage: NextPage<AwardPointsPageProps> = ({
     } catch (error) {
       showToast('An error occurred');
     }
-    // TODO
+
   };
 
   return (
@@ -68,7 +67,7 @@ const AwardPointsPage: NextPage<AwardPointsPageProps> = ({
         error={errors.email}
       />
       <VerticalFormItem
-        icon={<AiOutlineArrowDown />}
+        icon={<AiOutlineCalendar />}
         element="select"
         name="event"
         options={allEvents.map(event => event.title)}

diff --git a/src/pages/admin/milestone.tsx b/src/pages/admin/milestone.tsx
@@ -10,7 +10,7 @@ import withAccessType, { GetServerSidePropsWithAuth } from '@/lib/hoc/withAccess
 import { PermissionService } from '@/lib/services';
 import type { NextPage } from 'next';
 import { SubmitHandler, useForm } from 'react-hook-form';
-import { AiOutlineMail } from 'react-icons/ai';
+import { AiOutlineStar } from 'react-icons/ai';
 import { VscLock } from 'react-icons/vsc';
 
 interface FormValues {
@@ -29,7 +29,7 @@ const AwardPointsPage: NextPage<AwardPointsPageProps> = ({ authToken }) => {
   } = useForm<FormValues>();
 
   const onSubmit: SubmitHandler<FormValues> = async ({ name, points }) => {
-    // TODO
+
     try {
       await AdminAPI.createMilestone(authToken, name, Number(points));
       showToast('Successfully awarded attendance!');
@@ -45,7 +45,7 @@ const AwardPointsPage: NextPage<AwardPointsPageProps> = ({ authToken }) => {
         description="Award points to all active users (e.g. for ACM's 8 year anniversary)"
       />
       <VerticalFormItem
-        icon={<AiOutlineMail />}
+        icon={<AiOutlineStar />}
         element="input"
         name="name"
         type="text"

diff --git a/src/pages/admin/points.tsx b/src/pages/admin/points.tsx
@@ -12,7 +12,7 @@ import { AdminAPI, EventAPI } from '@/lib/api';
 
 import type { NextPage } from 'next';
 import { SubmitHandler, useForm } from 'react-hook-form';
-import { AiOutlineMail, AiOutlineArrowDown } from 'react-icons/ai';
+import { AiOutlineMail, AiOutlineCalendar } from 'react-icons/ai';
 import { VscLock } from 'react-icons/vsc';
 
 interface FormValues {
@@ -62,7 +62,7 @@ const AwardPointsPage: NextPage<AwardPointsPageProps> = ({
       />
 
       <VerticalFormItem
-        icon={<AiOutlineArrowDown />}
+        icon={<AiOutlineCalendar />}
         element="select"
         name="event"
         options={properEvents}
@@ -73,11 +73,11 @@ const AwardPointsPage: NextPage<AwardPointsPageProps> = ({
         error={errors.event}
       />
       <VerticalFormItem
-        icon={<AiOutlineArrowDown />}
+        icon={<AiOutlineMail />}
         element="select-multiple"
         name="email"
         options={sortedEmails}
-        placeholder="Select a User"
+        placeholder=""
         formRegister={register('email', {
           required: 'Required',
         })}