Trailing ? and prop name

acmucsd · Mar 30, 2024 · b6df3fa · b6df3fa
1 parent f13e8c3
commit b6df3fa
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/components/events/EventCarousel/index.tsx b/src/components/events/EventCarousel/index.tsx
@@ -19,7 +19,7 @@ interface EventCarouselProps {
   attendances: PublicAttendance[];
   placeholder: string;
   className?: string;
-  linkFilters?: FilterEventOptions;
+  initialEventFilters?: FilterEventOptions;
 }
 
 const EventCarousel = ({
@@ -29,8 +29,10 @@ const EventCarousel = ({
   attendances,
   placeholder,
   className = '',
-  linkFilters = {},
+  initialEventFilters = {},
 }: EventCarouselProps) => {
+  const eventQueryParams = new URLSearchParams(initialEventFilters).toString();
+
   return (
     <div className={`${styles.wrapper} ${className}`}>
       <div className={styles.header}>
@@ -41,7 +43,7 @@ const EventCarousel = ({
         </div>
         <Link
           className={styles.viewToggle}
-          href={`${config.eventsRoute}?${new URLSearchParams(linkFilters).toString()}`}
+          href={`${config.eventsRoute}${eventQueryParams ? `?${eventQueryParams}` : ''}`}
         >
           See all events &gt;
         </Link>

diff --git a/src/pages/index.tsx b/src/pages/index.tsx
@@ -150,7 +150,7 @@ const PortalHomePage = ({
 
       <EventCarousel
         title="Upcoming Events"
-        linkFilters={{ date: 'upcoming' }}
+        initialEventFilters={{ date: 'upcoming' }}
         titleClassName={styles.subheading}
         events={upcomingEvents}
         attendances={attendance}
@@ -159,7 +159,7 @@ const PortalHomePage = ({
       />
 
       <EventCarousel
-        linkFilters={{ attended: 'attended', date: 'all-time' }}
+        initialEventFilters={{ attended: 'attended', date: 'all-time' }}
         title="Recently Attended Events"
         titleClassName={styles.subheading}
         events={attendedEvents}