Andy/complete cancel pickup events #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed text wrap issue Also updated Button component to take in class names
Updated button styling for pickup event page Updated common Button component styling to auto expand to content Hide the complete/cancel buttons if the event isn't active
…acmucsd/membership-portal-ui-v2 into andy/completeCancelPickupEvents
If you clicked the select a pickup event toggle but didn't select an event, the API call wouldn't work b/c the linkedEventUuid would be '', not null. Fixed the issue by changing value to be null when linkedEventUuid is ''
WishingWell13
requested review from
farisashai,
raymosun,
trevorkw7,
SheepTester and
alexzhang1618
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
raymosun
requested changes
Apr 10, 2024
You have to specify the key name like linkedEventUuid: linkedEventUuid || null the shorthand only works if you pass in a single variable that’s used as the key and value like u did for title
added a popup instead
src/components/admin/event/AdminPickupEvent/AdminPickupEventForm.tsx
Outdated
Show resolved
Hide resolved
for complete and cancel functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
Closes #219 .
Fixed Linked Event Dropdown Breaks After Click and No Select For Admin Pickup Event Page
Changes
Type of Change
expected)
linting/formatting)
workflows)
Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
/src/lib/*and commented hard to understand areasanywhere else.
Screenshots
(ignore timer, is an extension)
