Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store: show second merch image on hover #235

Merged
merged 10 commits into from
May 4, 2024

Conversation

SheepTester
Copy link
Member

@SheepTester SheepTester commented Apr 24, 2024

Info

Closes #233

It does a little animation when you hover on the item card and it reveals the second image

I wanted it to do an ACM diamond shape but apparently it's complicated because clip-path: path() doesnt support percentages

Changes

  • [Fill in here]

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

2024-04-25.11-56-55.mp4

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2024 8:50pm
testing-membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2024 8:50pm

@SheepTester SheepTester marked this pull request as ready for review April 30, 2024 02:13
Copy link
Contributor

@alexzhang1618 alexzhang1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird little bug where if you're admin and you view as member, the pencil appears on the hover photo

Screen.Recording.2024-05-04.at.1.39.23.PM.mov

@SheepTester
Copy link
Member Author

fixed

Copy link
Contributor

@alexzhang1618 alexzhang1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🤑

@SheepTester SheepTester merged commit ac77e3b into main May 4, 2024
8 checks passed
@SheepTester SheepTester deleted the sean/hover-collection-second-image branch May 4, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show second merch item on merch card hover if exists
2 participants