Use Pacific Time on server side #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SheepTester
requested review from
farisashai,
raymosun,
trevorkw7 and
alexzhang1618
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alexzhang1618
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
4 am?? oops
Uses Pacific Time when displaying dates on server side only. The client continues to use local time.
Changes
It seems the Vercel servers are in a different time zone (maybe UTC?), so when displaying dates on the server side, I changed it to use the America/Los_Angeles time zone. This fixes the times rendered in event web previews. The client uses local time, like before.
An alternative option would be to force Pacific Time on the client. This could make sense since ACM at UCSD is based in California. However, we still host online events like Leetcode sessions, and people might be attending them from outside of California, so it would be helpful to continue showing them the event's time in their time zone.
Type of Change
expected)
linting/formatting)
workflows)
Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
/src/lib/*and commented hard to understand areasanywhere else.
Screenshots
the event image says october 2 but i don't think that's my fault