Code

Write events test suite#181

Code

Closed

shravanhariharan2 wants to merge 35 commits intomasteracmucsd/membership-portal:masterfrom tests/eventsacmucsd/membership-portal:tests/eventsCopy head branch name to clipboard

+480-163

Commits

Commits on Apr 18, 2021

• Add skeleton event tests

  shravanhariharan2

  committed
  c12ac20

  Copy full SHA for c12ac20

• Add missing await to EventService::createEvent

  shravanhariharan2

  committed
  ef89fa3

  Copy full SHA for ef89fa3

• Add rest of CRUD operation tests

  shravanhariharan2

  committed
  bc43ff9

  Copy full SHA for bc43ff9

Commits on Apr 20, 2021

• Add storage utils for mocking images to upload

  shravanhariharan2

  committed
  ce6dcb8

  Copy full SHA for ce6dcb8

Commits on Apr 24, 2021

• Add event feedback fakes

  shravanhariharan2

  committed
  290c828

  Copy full SHA for 290c828

• Add empty file check for storage test utils

  shravanhariharan2

  committed
  159d169

  Copy full SHA for 159d169

• Refactor EventFactory to fake past, ongoing, and future events easily

  shravanhariharan2

  committed
  bbaedc2

  Copy full SHA for bbaedc2

• Remove unused validator in feedback

  shravanhariharan2

  committed
  6a9b5ae

  Copy full SHA for 6a9b5ae

• Finish writing preliminary event tests

  shravanhariharan2

  committed
  74db6ba

  Copy full SHA for 74db6ba

• Merge branch 'master' into tests/events

  shravanhariharan2

  committed
  d2fd439

  Copy full SHA for d2fd439

Commits on May 4, 2021

• Update tests/event.test.ts

  Show description for 8d7623d
  

  shravanhariharan2

  and

  sumeet-bansal

  authored
  8d7623d

  Copy full SHA for 8d7623d

• Refactor EventFactory fake methods

  shravanhariharan2

  committed
  a264273

  Copy full SHA for a264273

• Inline all error messages that are only used once

  shravanhariharan2

  committed
  caa4f92

  Copy full SHA for caa4f92

• Fix small event test nits

  shravanhariharan2

  committed
  a33bcd0

  Copy full SHA for a33bcd0

Commits on May 6, 2021

• Merge branch 'master' into tests/events

  shravanhariharan2

  committed
  fcc0e4a

  Copy full SHA for fcc0e4a

• Change controller params in test to match updated validation format

  shravanhariharan2

  committed
  e56e157

  Copy full SHA for e56e157

• Move asserts next to data fetches

  shravanhariharan2

  committed
  cc6f83b

  Copy full SHA for cc6f83b

• Refactor EventFactory random time generation

  shravanhariharan2

  committed
  8ef3ea1

  Copy full SHA for 8ef3ea1

Commits on May 18, 2021

• Merge branch 'master' into tests/events

  shravanhariharan2

  committed
  5b3fa0c

  Copy full SHA for 5b3fa0c

• Switch to non-deprecated hexadecimal generation

  shravanhariharan2

  committed
  6e55d48

  Copy full SHA for 6e55d48

Commits on May 21, 2021

• mocking with jest sucks

  shravanhariharan2

  committed
  2f8c3b4

  Copy full SHA for 2f8c3b4

Commits on May 27, 2021

• Add 'update event' tests

  shravanhariharan2

  committed
  2529a86

  Copy full SHA for 2529a86

• Make event patches fields explicitly optional in validation (they were optional before but implicitly)

  shravanhariharan2

  committed
  28a55ca

  Copy full SHA for 28a55ca

• Allow mocked services to be injected into controllers

  shravanhariharan2

  committed
  ede38bf

  Copy full SHA for ede38bf

• Remove redundant type

  shravanhariharan2

  committed
  539d35e

  Copy full SHA for 539d35e

• Switch mocking aws-sdk to StorageService using ts-mockito

  shravanhariharan2

  committed
  18a952c

  Copy full SHA for 18a952c

Commits on Jul 17, 2021

• Merge branch 'master' into tests/events

  shravanhariharan2

  committed
  342dcb5

  Copy full SHA for 342dcb5

• Move ts-mockito from dep to devDep

  shravanhariharan2

  committed
  a70a68e

  Copy full SHA for a70a68e

• Remove singleton behavior from ControllerFactory

  shravanhariharan2

  committed
  cc1694b

  Copy full SHA for cc1694b

• Move controllers/index.ts -> ControllerFactory.ts

  shravanhariharan2

  committed
  9b51a89

  Copy full SHA for 9b51a89

• Move createEventFeedback from FeedbackFactory to EventFactory

  shravanhariharan2

  committed
  3ecb774

  Copy full SHA for 3ecb774

• Move fakeOngoingEvent start duration forward 30 minutes

  shravanhariharan2

  committed
  2c5ca2a

  Copy full SHA for 2c5ca2a

• Tighten error handling to match constraint in test

  shravanhariharan2

  committed
  a88706e

  Copy full SHA for a88706e

• Lint

  shravanhariharan2

  committed
  98023da

  Copy full SHA for 98023da

• Add get call to event cover test to ensure cover is persisted

  shravanhariharan2

  committed
  298f5f3

  Copy full SHA for 298f5f3